[ https://issues.apache.org/jira/browse/SPARK-12725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15125252#comment-15125252 ]
Xiao Li commented on SPARK-12725: --------------------------------- Recently, I am working on a PR related to ResolveAggregateFunctions. Could we just change the rule ResolveAggregateFunctions and generate a unique alias name without any conflict? It will be a very simple fix, if it works. As [~lian cheng] said, put the expression id in the name, since the generated name will not be exposed to the users. This idea has been used in the code. > SQL generation suffers from name conficts introduced by some analysis rules > --------------------------------------------------------------------------- > > Key: SPARK-12725 > URL: https://issues.apache.org/jira/browse/SPARK-12725 > Project: Spark > Issue Type: Sub-task > Components: SQL > Reporter: Cheng Lian > > Some analysis rules generate auxiliary attribute references with the same > name but different expression IDs. For example, {{ResolveAggregateFunctions}} > introduces {{havingCondition}} and {{aggOrder}}, and > {{DistinctAggregationRewriter}} introduces {{gid}}. > This is OK for normal query execution since these attribute references get > expression IDs. However, it's troublesome when converting resolved query > plans back to SQL query strings since expression IDs are erased. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org