[
https://issues.apache.org/jira/browse/SPARK-13986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongjoon Hyun updated SPARK-13986:
----------------------------------
Description:
Spark uses `@DeveloperApi` annotation, but sometimes it seems to conflict with
its visibility. This issue proposes to fix those conflict. The following is the
example.
{code:title=JobResult.scala|borderStyle=solid}
@DeveloperApi
sealed trait JobResult
@DeveloperApi
case object JobSucceeded extends JobResult
-@DeveloperApi
private[spark] case class JobFailed(exception: Exception) extends JobResult
{code}
According to the review comments, the annotation should be removed.
was:
Spark uses `@DeveloperApi` annotation, but sometimes it seems to conflict with
its visibility. This issue proposes to fix those conflict. The following is the
example.
{code:title=JobResult.scala|borderStyle=solid}
@DeveloperApi
sealed trait JobResult
@DeveloperApi
case object JobSucceeded extends JobResult
@DeveloperApi
-private[spark] case class JobFailed(exception: Exception) extends JobResult
+case class JobFailed(exception: Exception) extends JobResult
{code}
> Remove `DeveloperApi`-annotation for non-publics
> ------------------------------------------------
>
> Key: SPARK-13986
> URL: https://issues.apache.org/jira/browse/SPARK-13986
> Project: Spark
> Issue Type: Improvement
> Components: MLlib, Spark Core
> Reporter: Dongjoon Hyun
> Priority: Minor
>
> Spark uses `@DeveloperApi` annotation, but sometimes it seems to conflict
> with its visibility. This issue proposes to fix those conflict. The following
> is the example.
> {code:title=JobResult.scala|borderStyle=solid}
> @DeveloperApi
> sealed trait JobResult
> @DeveloperApi
> case object JobSucceeded extends JobResult
> -@DeveloperApi
> private[spark] case class JobFailed(exception: Exception) extends JobResult
> {code}
> According to the review comments, the annotation should be removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
