Jungtaek Lim created STORM-2142:
-----------------------------------
Summary: ReportErrorAndDie runs suicide function only when
InterruptedException or InterruptedIOException is thrown
Key: STORM-2142
URL: https://issues.apache.org/jira/browse/STORM-2142
Project: Apache Storm
Issue Type: Bug
Components: storm-core
Affects Versions: 2.0.0
Reporter: Jungtaek Lim
Priority: Critical
When EvaluationFilter / EvaluationFunction throws Exception, async loop for the
executor is died but others will continue to work.
{code}
2016-10-08 14:12:29.597 o.a.s.u.Utils
Thread-23-b-0-LOGICALFILTER_6-LOGICALPROJECT_7-executor[5 5] [ERROR] Async loop
died!
java.lang.RuntimeException: java.lang.RuntimeException:
java.lang.reflect.InvocationTargetException
at
org.apache.storm.utils.DisruptorQueue.consumeBatchToCursor(DisruptorQueue.java:468)
~[storm-core-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
...
Caused by: java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
~[?:1.8.0_66]
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
~[?:1.8.0_66]
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
~[?:1.8.0_66]
at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_66]
at
org.codehaus.janino.ScriptEvaluator.evaluate(ScriptEvaluator.java:982)
~[dep-janino-2.7.6-dcb5bd18-a5dd-4976-a967-0108dcf46df0.jar.1475903522000:2.7.6]
...
Caused by: java.lang.RuntimeException: Cannot convert null to int
at
org.apache.calcite.runtime.SqlFunctions.cannotConvert(SqlFunctions.java:1023)
~[dep-calcite-core-1.9.0-e7846de7-7024-4041-89e4-67dd5edf31e8.jar.1475903521000:1.9.0]
at
org.apache.calcite.runtime.SqlFunctions.toInt(SqlFunctions.java:1134)
~[dep-calcite-core-1.9.0-e7846de7-7024-4041-89e4-67dd5edf31e8.jar.1475903521000:1.9.0]
at SC.eval0(Unknown Source) ~[?:?]
{code}
While looking into detail, I found that ReportErrorAndDie implementation seems
odd - completely opposite behavior compared to 1.x :report-error-and-die.
When InterruptedException or InterruptedIOException is thrown, it should just
leave a log and shouldn't run suicide function. For others it should run
suicide function.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
