[
https://issues.apache.org/jira/browse/STORM-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989707#comment-15989707
]
Mal Graty commented on STORM-2421:
----------------------------------
Here's a snippet from one of our {{storm.yaml}} files:
{code}
ui.childopts: -Xmx768m -Dsentry.tags=env:development
worker.childopts:
- -Djava.util.logging.manager=org.apache.logging.log4j.jul.LogManager
- -XX:+UseConcMarkSweepGC
- -Xmx%HEAP-MEM%m
{code}
As you can see we can provide a list/array of strings/flags to
{{worker.childopts}} but must supply a string to {{ui.childopts}}, this is a
request to broaden the support for lists/arrays to all types of childopt
configuration values. This also follows the principal of least surprise (all
childopts values behave the same) :) So the desired {{storm.yaml}} would look
like:
{code}
ui.childopts:
- -Xmx768m
- -Dsentry.tags=env:development
worker.childopts:
- -Djava.util.logging.manager=org.apache.logging.log4j.jul.LogManager
- -XX:+UseConcMarkSweepGC
- -Xmx%HEAP-MEM%m
{code}
> Support lists of childopts beyond just worker
> ---------------------------------------------
>
> Key: STORM-2421
> URL: https://issues.apache.org/jira/browse/STORM-2421
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Affects Versions: 1.0.2
> Reporter: Mal Graty
> Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The following worker childopts configuration options all support both a
> string value and a list of strings value:
> {code}
> WORKER_CHILDOPTS
> WORKER_PROFILER_CHILDOPTS
> WORKER_GC_CHILDOPTS
> TOPOLOGY_WORKER_CHILDOPTS
> TOPOLOGY_WORKER_GC_CHILDOPTS
> TOPOLOGY_WORKER_LOGWRITER_CHILDOPTS
> {code}
> Currently the following childopts configuration options only support strings:
> {code}
> NIMBUS_CHILDOPTS
> LOGVIEWER_CHILDOPTS
> UI_CHILDOPTS
> PACEMAKER_CHILDOPTS
> DRPC_CHILDOPTS
> SUPERVISOR_CHILDOPTS
> {code}
> Please could lists be supported across all childopts options as it makes
> configuration management and building easier using automated tools such as
> Chef and Puppet.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
