[ 
https://issues.apache.org/jira/browse/STORM-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jungtaek Lim resolved STORM-2479.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 2.0.0

Thanks [~Srdo], merged into master.

> DRPC tests should not use Utils.getAvailablePort, since that function is 
> inherently unsafe
> ------------------------------------------------------------------------------------------
>
>                 Key: STORM-2479
>                 URL: https://issues.apache.org/jira/browse/STORM-2479
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Stig Rohde Døssing
>            Assignee: Stig Rohde Døssing
>            Priority: Minor
>             Fix For: 2.0.0
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> The DRPC tests should avoid using Utils.getAvailablePort. That method for 
> getting an unused port is prone to race conditions, since there is no 
> guarantee that a port that is found using getAvailablePort is still available 
> when the returned port is actually used to create a socket. There is also no 
> guarantee that the same port is not returned to multiple threads.
> The tests should instead pass a random port to the servers underlying 
> DRPCServer, and ask those servers which ports they're running on when they've 
> started.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to