[
https://issues.apache.org/jira/browse/STORM-2568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060423#comment-16060423
]
Jungtaek Lim commented on STORM-2568:
-------------------------------------
[~haewanj]
You seem to already have patch for this issue. Could you provide pull request
for the patch if you don't mind?
You can refer below link to see how to contribute code:
https://github.com/apache/storm/blob/master/DEVELOPER.md
If you don't want to dive into submitting pull request, please feel free to let
me know so that I or someone could work on this.
Thanks in advance!
> Wrong configuration 'groupid' to get lag for new kafka spout
> ------------------------------------------------------------
>
> Key: STORM-2568
> URL: https://issues.apache.org/jira/browse/STORM-2568
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 1.1.0
> Reporter: Haewan Jeong
>
> Hello
> I've tried to use storm-kafka-monitor, and it works fine on command line If I
> changed 'toollib/storm-kafka-monitor-*.jar' to
> 'toollib/storm-kafka-monitor-1.1.0.jar'.
> but it gives empty result when I call below api.
> {code}
> /api/v1/topology/:id/lag
> ...
> {
> "MySpoutName": {
> "spoutLagResult": {},
> "spoutId": "MySpoutName",
> "spoutType": "KAFKA"
> }
> }
> {code}
> I think that needs to fix "groupid" to "group.id" in TopologySpoutLag.java
> {code}
> package org.apache.storm.utils;
> public class TopologySpoutLag {
> ...
> commands.add((String)jsonConf.get(configKeyPrefix + "groupid"));
> {code}
> {code}
> package org.apache.storm.kafka.spout;
> public class KafkaSpoutConfig<K, V> implements Serializable {
> ...
> public String getConsumerGroupId() {
> return (String)this.kafkaProps.get("group.id");
> }
> ...
> public KafkaSpoutConfig.Builder<K, V> setGroupId(String id) {
> return this.setProp("group.id", id);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
