Dhiraj Sardana created STORM-2661:
-------------------------------------

             Summary: JmsSpout should support additional ack mode or should 
have option for child classes
                 Key: STORM-2661
                 URL: https://issues.apache.org/jira/browse/STORM-2661
             Project: Apache Storm
          Issue Type: Improvement
          Components: storm-jms
    Affects Versions: 1.1.0
            Reporter: Dhiraj Sardana
            Priority: Minor


Currently , JmsSpout supports 3 acknowledge modes. But some of the queue 
Providers (like Solace) supports some more ack modes. Like :
Sol_client_ack which acknowledges each message individually to support 
Guaranteed Delivery.
As JmsSpout's 'jmsAcknowledgeMode' is private and setter has validations, so we 
can't simply extend JmsSpout(and override required APIs only) to support this 
additional features. We need to take the complete code.

JmsSpout reference Url 
:https://github.com/apache/storm/blob/v1.1.0/external/storm-jms/src/main/java/org/apache/storm/jms/spout/JmsSpout.java

So, either there should be support for enhancements by child classes or 
this additional ack mode(which seems generic requirement) should be included in 
JmsSpout itself - we've some reference code which is working fine. can share 
the same if required.  




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to