[ 
https://issues.apache.org/jira/browse/STORM-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated STORM-2834:
----------------------------------
    Labels: pull-request-available  (was: )

> getOwnerResourceSummaries not working properly because scheduler is wrapped 
> as BlacklistScheduler
> -------------------------------------------------------------------------------------------------
>
>                 Key: STORM-2834
>                 URL: https://issues.apache.org/jira/browse/STORM-2834
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Ethan Li
>            Assignee: Ethan Li
>            Priority: Minor
>              Labels: pull-request-available
>
> https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java#L4101
> {code:java}
>  if (clusterSchedulerConfig.containsKey(theOwner)) {
>                     if (scheduler instanceof ResourceAwareScheduler) {
>                         Map<String, Object> schedulerConfig = (Map) 
> clusterSchedulerConfig.get(theOwner);
>                         if (schedulerConfig != null) {
>                             
> ownerResourceSummary.set_memory_guarantee((double)schedulerConfig.getOrDefault("memory",
>  0));
>                             
> ownerResourceSummary.set_cpu_guarantee((double)schedulerConfig.getOrDefault("cpu",
>  0));
>                             
> ownerResourceSummary.set_memory_guarantee_remaining(ownerResourceSummary.get_memory_guarantee()
>                                     - 
> ownerResourceSummary.get_memory_usage());
>                             
> ownerResourceSummary.set_cpu_guarantee_remaining(ownerResourceSummary.get_cpu_guarantee()
>                                     - ownerResourceSummary.get_cpu_usage());
>                         }
>                     } else if (scheduler instanceof  MultitenantScheduler) {
>                         
> ownerResourceSummary.set_isolated_node_guarantee((int) 
> clusterSchedulerConfig.getOrDefault(theOwner, 0));
>                     }
>                 }
> {code}
> Because scheduler is wrapped as BlackListScheduler 
> (https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java#L474),
>  these two "instanceof" will never be true.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to