[ 
https://issues.apache.org/jira/browse/STORM-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304176#comment-16304176
 ] 

Jungtaek Lim commented on STORM-1188:
-------------------------------------

[~dan.blanchard]
How do you define the topology with accessing PartialKeyGrouping outside of 
JVM? I guess if PartialKeyGrouping is accessible and initializable, Fields is 
expected to be accessible too, hence asking the question.

Btw, I'm not familiar with backward-compatibility manner of Thrift, so I'm sure 
I might be missing here, but as far as I googled it (sad) adding field into 
"union" doesn't look like backward compatible. For "struct" we are adding new 
things as "optional" but "union" doesn't provide that option.

> PartialKeyGrouping missing from storm.thrift (and can't use it via 
> custom_object)
> ---------------------------------------------------------------------------------
>
>                 Key: STORM-1188
>                 URL: https://issues.apache.org/jira/browse/STORM-1188
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-core
>    Affects Versions: 0.10.0, 1.0.0, 0.10.1, 1.0.1, 0.10.2, 1.0.2, 1.1.0, 
> 1.0.3, 1.x, 0.10.3, 1.0.4, 1.1.1, 1.0.5
>            Reporter: Dan Blanchard
>
> I'm working on a Python DSL for Storm to add to streamparse, and as part of 
> it I realized that the new partial key grouping was never added to the 
> Grouping struct in storm.thrift, so it's not usable outside of JVM-based 
> topology definitions (at least not easily).  My initial thought was to just 
> use Grouping.custom_object, but the PartialKeyGrouping constructor takes a 
> Fields object, which isn't a type defined in storm.thrift, so I can't use it.
> The fields grouping explicitly takes a list of strings in storm.thrift, so it 
> would seem PartialKeyGrouping needs to be added in the same way.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to