Stig Rohde Døssing created STORM-3064:
-----------------------------------------

             Summary: PartitionedTridentSpoutExecutor should use 
getPartitionsForTask
                 Key: STORM-3064
                 URL: https://issues.apache.org/jira/browse/STORM-3064
             Project: Apache Storm
          Issue Type: Improvement
          Components: storm-client
    Affects Versions: 2.0.0
            Reporter: Stig Rohde Døssing


https://issues.apache.org/jira/browse/STORM-2407 added a method to the 
IOpaquePartitionedTridentSpout.Emitter interface called getPartitionsForTask, 
which is now used to delegate partitioning between tasks (previously, the 
partitioning was hard coded to round robin).

If we want to be able to delegate partitioning, I don't see a reason not to 
make the same change on the IPartitionedTridentSpout.Emitter interface, where 
partitioning is still hard coded to use round robin. E.g. compare 
https://github.com/apache/storm/blob/4137328b75c06771f84414c3c2113e2d1c757c08/storm-client/src/jvm/org/apache/storm/trident/spout/PartitionedTridentSpoutExecutor.java#L131
 to 
https://github.com/apache/storm/blob/4137328b75c06771f84414c3c2113e2d1c757c08/storm-client/src/jvm/org/apache/storm/trident/spout/OpaquePartitionedTridentSpoutExecutor.java#L131



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to