[ https://issues.apache.org/jira/browse/STORM-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500410#comment-16500410 ]
Ethan Li commented on STORM-3092: --------------------------------- Sorry I mis-click something and changed the summary.. changed it back. > Metrics Reporter and Shutdown Hook on Supervisor not properly set up at > launchDaemon > ------------------------------------------------------------------------------------ > > Key: STORM-3092 > URL: https://issues.apache.org/jira/browse/STORM-3092 > Project: Apache Storm > Issue Type: Bug > Components: storm-server > Affects Versions: 2.0.0 > Reporter: Zhengdai Hu > Assignee: Zhengdai Hu > Priority: Major > Labels: pull-request-available > Fix For: 2.0.0 > > Original Estimate: 24h > Time Spent: 10m > Remaining Estimate: 23h 50m > > The bug was introduced in commit 0dac58b0aa82133df242b3b2ebeb65bfea7d63cc, > when launchSupervisorThriftServer method is invoked in the launchDaemon > method in Supervisor class. launchSupervisorThriftServer() invokes a blocking > call to thrift server under the hood, hence preventing > Utils.addShutdownHookWithForceKillIn1Sec and > StormMetricsRegistry.startMetricsReporters from correctly called. > > The bug can be solved by moving launchSupervisorThriftServer to the end of > the code block. -- This message was sent by Atlassian JIRA (v7.6.3#76005)