[
https://issues.apache.org/jira/browse/STORM-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jungtaek Lim resolved STORM-3094.
---------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0
Thanks [~ManoharVanam], I merged into master.
If you would like to port this back to 1.x, please raise a pull request against
1.x-branch.
> Topology name needs to be validated at storm-client
> ---------------------------------------------------
>
> Key: STORM-3094
> URL: https://issues.apache.org/jira/browse/STORM-3094
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-client
> Reporter: Manohar Vanam
> Assignee: Manohar Vanam
> Priority: Minor
> Labels: pull-request-available
> Fix For: 2.0.0
>
> Attachments: patch.diff
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> *Current Behavior :* Execute topology with invalid topology name is throwing
> exception after uploading the jar.
> *Improvement :* Validating topology name at client side before uploading the
> jar.
>
>
> {code:java}
> 2018-06-05 16:16:19.461 o.a.s.d.n.Nimbus pool-21-thread-53 [INFO] Uploading
> file from client to
> /manu/Git/storm/storm-dist/binary/final-package/target/apache-storm-2.0.0-SNAPSHOT/storm-local/nimbus/inbox/stormjar-22979659-5176-46fd-9027-ffdde13f595a.jar
> 2018-06-05 16:16:20.596 o.a.s.d.n.Nimbus pool-21-thread-35 [INFO] Finished
> uploading file from client:
> /manu/Git/storm/storm-dist/binary/final-package/target/apache-storm-2.0.0-SNAPSHOT/storm-local/nimbus/inbox/stormjar-22979659-5176-46fd-9027-ffdde13f595a.jar
> 2018-06-05 16:16:20.624 o.a.s.d.n.Nimbus pool-21-thread-29 [INFO] Received
> topology submission for test-[123] (storm-2.0.0-SNAPSHOT JDK-1.8.0_162) with
> conf {topology.users=[null], topology.acker.executors=null,
> storm.zookeeper.superACL=null, topology.workers=3,
> topology.submitter.principal=, topology.debug=true, topology.name=test-[123],
> topology.kryo.register={}, storm.id=test-[123]-7-1528195580,
> topology.kryo.decorators=[], topology.eventlogger.executors=0,
> topology.submitter.user=mvanam, topology.max.task.parallelism=null}
> 2018-06-05 16:16:20.624 o.a.s.d.n.Nimbus pool-21-thread-29 [INFO] uploadedJar
> /manu/Git/storm/storm-dist/binary/final-package/target/apache-storm-2.0.0-SNAPSHOT/storm-local/nimbus/inbox/stormjar-22979659-5176-46fd-9027-ffdde13f595a.jar
> 2018-06-05 16:16:20.624 o.a.s.b.BlobStore pool-21-thread-29 [ERROR]
> 'test-[123]-7-1528195580-stormjar.jar' does not appear to be valid. It must
> match ^[\w \t\._-]+$. And it can't be ".", "..", null or empty string.
> 2018-06-05 16:16:20.625 o.a.s.b.BlobStore pool-21-thread-29 [ERROR]
> 'test-[123]-7-1528195580-stormconf.ser' does not appear to be valid. It must
> match ^[\w \t\._-]+$. And it can't be ".", "..", null or empty string.
> 2018-06-05 16:16:20.626 o.a.s.d.n.Nimbus pool-21-thread-29 [WARN] Topology
> submission exception. (topology name='test-[123]')
> java.lang.IllegalArgumentException: test-[123]-7-1528195580-stormconf.ser
> does not appear to be a valid blob key
> at org.apache.storm.blobstore.BlobStore.validateKey(BlobStore.java:66)
> ~[storm-client-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]{code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
