Stig Rohde Døssing created STORM-3155:
-----------------------------------------

             Summary: IOutputSerializer implementations always allocates a new 
ByteBuffer
                 Key: STORM-3155
                 URL: https://issues.apache.org/jira/browse/STORM-3155
             Project: Apache Storm
          Issue Type: Task
          Components: storm-sql
    Affects Versions: 2.0.0
            Reporter: Stig Rohde Døssing


The IOutputSerializer javadoc specifies that the user may optionally provide a 
ByteBuffer to serialize into.

https://github.com/apache/storm/blob/af42f434f4a4c3d9087c6058b359033736d3b5e8/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/IOutputSerializer.java#L26

None of the IOutputSerializer implementations we ship with actually do this. 
They all ignore the ByteBuffer parameter.

If this is a useful feature, I think that we should update them to use the 
supplied ByteBuffer if not null. If it isn't a useful feature, we should 
instead remove the ByteBuffer parameter from the API.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to