[ https://issues.apache.org/jira/browse/STORM-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhengdai Hu updated STORM-3170: ------------------------------- Description: In DirectoryCleaner#deleteOldestWhileTooLarge, the original implementation calls file#delete without checking if it succeeds or not, even though they're always reported as deleted. This prevents DirectoryCleaner from clean up other files and invalidates any metrics built on top of this. (was: In DirectoryCleaner#deleteOldestWhileTooLarge, the original implementation calls file#delete without checking if it succeed or not, even though they're always reported as deleted. This prevents DirectoryCleaner from clean up other files and invalidates any metrics built on top of this.) > DirectoryCleaner may not correctly report correct number of deleted files > ------------------------------------------------------------------------- > > Key: STORM-3170 > URL: https://issues.apache.org/jira/browse/STORM-3170 > Project: Apache Storm > Issue Type: Bug > Components: storm-webapp > Affects Versions: 2.0.0 > Reporter: Zhengdai Hu > Assignee: Zhengdai Hu > Priority: Major > Labels: pull-request-available > Fix For: 2.0.0 > > Time Spent: 10m > Remaining Estimate: 0h > > In DirectoryCleaner#deleteOldestWhileTooLarge, the original implementation > calls file#delete without checking if it succeeds or not, even though they're > always reported as deleted. This prevents DirectoryCleaner from clean up > other files and invalidates any metrics built on top of this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)