[
https://issues.apache.org/jira/browse/STORM-3529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stig Rohde Døssing resolved STORM-3529.
---------------------------------------
Fix Version/s: 2.2.0
Assignee: Oliver Downard
Resolution: Fixed
Thanks for the fix [~olivermd], merged to master.
> Catch and log RetriableException in KafkaOffsetMetric
> -----------------------------------------------------
>
> Key: STORM-3529
> URL: https://issues.apache.org/jira/browse/STORM-3529
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-kafka-client
> Affects Versions: 2.0.0
> Reporter: Stig Rohde Døssing
> Assignee: Oliver Downard
> Priority: Major
> Labels: newbie, pull-request-available
> Fix For: 2.2.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> When the KafkaOffsetMetric.getValueAndReset method calls the KafkaClient
> methods, exceptions may be thrown. When these exceptions are retriable, we
> should not crash the worker by letting them escape the method. We should
> instead catch and log the exception.
> An example of the desired behavior can be seen at
> https://github.com/apache/storm/blob/7b1a98fc10fad516ef9ed0b3afc53a1d7be8a169/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java#L295
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
