[
https://issues.apache.org/jira/browse/STORM-2483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ethan Li resolved STORM-2483.
-----------------------------
Fix Version/s: 2.1.1
2.2.0
1.2.4
Resolution: Fixed
Thanks [~nd368]. Merged to the PRs to 1.x-branch, master respectively, and
cherry-picked to 2.1.x-branch
> wrong parameters order
> ----------------------
>
> Key: STORM-2483
> URL: https://issues.apache.org/jira/browse/STORM-2483
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 2.0.0, 1.0.3, 1.2.3, 2.1.0
> Environment: storm-core:1.0.3
> Reporter: Jacob Liu
> Assignee: Nathan Day
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.2.4, 2.2.0, 2.1.1
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> org.apache.storm.utils.Utils#getGlobalStreamId has wrong parameters order:
>
> public static GlobalStreamId getGlobalStreamId(String streamId, String
> componentId) {
> if (componentId == null) {
> return new GlobalStreamId(streamId, DEFAULT_STREAM_ID);
> }
> return new GlobalStreamId(streamId, componentId);
> }
> but GlobalStreamId constructor is: public GlobalStreamId(
> String componentId,
> String streamId)
> so i think the nice code is:
> public static GlobalStreamId getGlobalStreamId(String streamId, String
> componentId) {
> if (streamId == null) {
> return new GlobalStreamId(componentId, DEFAULT_STREAM_ID);
> }
> return new GlobalStreamId(componentId, streamId);
> }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
