[ 
https://issues.apache.org/jira/browse/STORM-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ethan Li updated STORM-3669:
----------------------------
    Description: 
For example, for 
https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java#L3150-L3151

validateTopologyWorkerMaxHeapSizeConfigs shouldn't be performed when a 
scheduler other than ResourceAwareScheduler is being used.

{code:java}
if (ServerUtils.isRas(conf))
{code}
OR
{code:java}
if (underlyingScheduler instanceof ResourceAwareScheduler)
{code}

can be used for this purpose.

  was:
For example, for 
https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java#L3150-L3151

validateTopologyWorkerMaxHeapSizeConfigs shouldn't be performed when a 
scheduler other than ResourceAwareScheduler is being used.

{code:java}
if (ServerUtils.isRas(conf))
{code}

can be used for this purpose.


> Validation against topology regarding to resource constraints should only be 
> performed when ResourceAwareScheduler is being used
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: STORM-3669
>                 URL: https://issues.apache.org/jira/browse/STORM-3669
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Ethan Li
>            Priority: Major
>
> For example, for 
> https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java#L3150-L3151
> validateTopologyWorkerMaxHeapSizeConfigs shouldn't be performed when a 
> scheduler other than ResourceAwareScheduler is being used.
> {code:java}
> if (ServerUtils.isRas(conf))
> {code}
> OR
> {code:java}
> if (underlyingScheduler instanceof ResourceAwareScheduler)
> {code}
> can be used for this purpose.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to