[
https://issues.apache.org/jira/browse/STORM-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bipin Prasad reassigned STORM-3683:
-----------------------------------
Assignee: Bipin Prasad
> Check for consistency in JVM options for worker launch
> ------------------------------------------------------
>
> Key: STORM-3683
> URL: https://issues.apache.org/jira/browse/STORM-3683
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-client
> Reporter: Bipin Prasad
> Assignee: Bipin Prasad
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> If GC options are specified in topology.worker.childopts, they could conflict
> with the cluster settings and cause problems launching the JVM. This leads to
> storm alerts due to failures launching containers.
> We could catch these on submission and prevent the topology from launching
> with an error message.
> *Kishor Patil's further comments:*
> Submit time validation of JVM Options includes..
> Running `java -showversion` kind of command while topology is being submitted
> using JVM_OPTIONS derived using
> # topology.worker.childopts
> # topology.worker.gc.childopts
> # topology.worker.logwriter.childopts
> # worker.childopts
> # worker.gc.childopts
> # worker.profiler.childopts
> And removing replacement strings such as "%ID%", "%WORKER-ID%",
> "%TOPOLOGY-ID%", "%WORKER-PORT", "%OFF-HEAP-MEM%", "%LIMIT-MEM%" with dummy
> values. To perform these replacements with dummy values, I would use
> externalize and use the logic from
> [BasicContainer#substituteChildOptsInternal|https://git.vzbuilders.com/storm/storm/blob/master/storm-server/src/main/java/org/apache/storm/daemon/supervisor/BasicContainer.java#L440]
> method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
