[
https://issues.apache.org/jira/browse/STORM-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ethan Li updated STORM-3700:
----------------------------
Affects Version/s: 2.2.0
2.0.0
2.1.0
> Stop flight recording from Storm UI doesn't work properly
> ---------------------------------------------------------
>
> Key: STORM-3700
> URL: https://issues.apache.org/jira/browse/STORM-3700
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 2.0.0, 2.1.0, 2.2.0
> Reporter: Ethan Li
> Priority: Major
>
> The code is implemented at
> [https://github.com/apache/storm/blob/36204eda00bca7e03ac3979d9c0d3527d1f08330/storm-server/src/main/java/org/apache/storm/daemon/supervisor/Slot.java#L841-L878]
>
> JPROFILE_STOP is used for both start flight recording and stop flight
> recording. The logic in the code is that if there is already a JPROFILE_STOP
> with the same topoId and request content (host, port, timestamp), the
> JPROFILE_STOP becomes a stop command; otherwise, it is a start command.
> But the problem is every time when we invoke stop on UI:
> [https://github.com/apache/storm/blob/3fb289b87c7d72bfe01ee1c7028adbc69f012439/storm-webapp/src/main/java/org/apache/storm/daemon/ui/resources/StormApiResource.java#L621-L631]
>
> the request is actually configured with timestamp=0:
> [https://github.com/apache/storm/blob/bb199d574eae337d0512670dcc4957f3c7ef4922/storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java#L2320]
> so it will never equal to any request in the pending profile action. So stop
> will never happen
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
