[ 
https://issues.apache.org/jira/browse/STORM-4017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803707#comment-17803707
 ] 

Scott Moore commented on STORM-4017:
------------------------------------

As an aside, the getRunningProcessIds in ServerUtilsTest.java does not return 
anything when run under Windows as the method assumes the pid is the first 
column entry returned from 'tasklist' - but this is not the case - it is the 
2nd column, so the testIsAnyProcessAlive unit test fails at the first 
assertFalse(pids.isEmpty())

I have fixes for all this. Will create a pull request shortly

> isAnyWindowsProcessAlive does not work with multiple pids
> ---------------------------------------------------------
>
>                 Key: STORM-4017
>                 URL: https://issues.apache.org/jira/browse/STORM-4017
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-server
>    Affects Versions: 2.3.0, 2.4.0, 2.5.0, 2.6.0
>         Environment: Windows
>            Reporter: Scott Moore
>            Priority: Major
>         Attachments: tasklist-multiple-pid-filters.png
>
>
> The method isAnyWindowsProcessAlive in ServerUtils.java does not work with 2 
> or more pids in the supplied pid collection
> The refactor done as part of STORM-3638 has made an incorrect assumption that 
> the 'tasklist' Windows tool can accept multiple arguments of "/fi pid eq 
> <id>" and treat this list as an 'or' list when, in fact, the /fi arguments 
> should be considered an 'and' list.
> e.g. tasklist /fi "pid eq 123" /fi "pid eq 456" means 'give me information on 
> processes where each process has a pid of 123 and 456'
> The effect of this means that isAnyWindowsProcessAlive will always return 
> false when given 2 or more (different) pids (i.e.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to