Ironankit525 commented on PR #8415: URL: https://github.com/apache/storm/pull/8415#issuecomment-3989937595
Thanks for the review @rzo1! I have implemented all the requested changes: - Removed the `File` object instantiation and moved to pure NIO (`Files.size`, `Files.exists`, `Files.createDirectories`). - - Introduced constants for the default config values. - - Lowered the default rotation size to 100 MB. - - Cleaned up the commit message and PR title. Let me know if anything else is needed! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
