jnioche opened a new pull request, #8453: URL: https://github.com/apache/storm/pull/8453
## Summary Port 36 tests from `storm-core/test/clj/org/apache/storm/nimbus_test.clj` to Java/JUnit 5 in `storm-server/src/test/java/org/apache/storm/daemon/nimbus/NimbusClojurePortTest.java`. Part of #8445 — removing the Clojure dependency from the Apache Storm build. ### Tests ported (36 total, in 4 batches): **Batch 7a (13 tests):** testBogusId, testNimbusIfaceSubmitTopologyWithOptsChecksAuthorization, testNimbusIfaceMethodsCheckAuthorization, testNimbusIfaceGetTopologyMethodsThrowCorrectly, testNimbusIfaceGetClusterInfoFiltersToposWithoutBases, testValidateTopoConfigOnSubmit, testDebugOnComponent, testDebugOnGlobal, emptySaveConfigResultsInAllUnchangedActions, logLevelUpdateMergesAndFlagsExistentLogLevel, cleanupStormIdsReturnsInactiveTopos, cleanupStormIdsPerformsUnionOfStormIdsWithActiveZnodes, cleanupStormIdsReturnsEmptySetWhenAllToposAreActive **Batch 7b (6 tests):** doCleanupRemovesInactiveZnodes, doCleanupDoesNotTeardownActiveTopos, userTopologiesForSupervisor, userTopologiesForSupervisorWithUnauthorizedUser, testCleanInbox, testSubmitInvalid **Batch 7c (5 tests):** testAssignment, testZeroExecutorOrTasks, testOverParallelismAssignment, testGetOwnerResourceSummaries, testAutoCredentials **Batch 7d (12 tests):** testIsolatedAssignment, testExecutorAssignments, testTopoHistory, testKillStorm, testReassignment, testReassignmentToConstrainedCluster, testReassignSqueezedTopology, testRebalance, testRebalanceChangeParallelism, testRebalanceConstrainedCluster, testNimbusCheckAuthorizationParams, testCheckAuthorizationGetSupervisorPageInfo ### Tests not ported (4): - **test-file-bogus-download**: `beginFileDownload` API has been removed from Nimbus - **test-leadership**, **test-stateless-with-scheduled-topology-to-be-killed**, **test-topology-action-notifier**: Require direct Nimbus+ZooKeeper construction with static mocking (`MockedZookeeper`/`MockLeaderElector` from storm-core) that causes JVM crashes (`System.exit`) from Nimbus timer threads ### New helper files: - `MockAutoCred.java` — duplicated from storm-core test sources (not on storm-server classpath) - `InMemoryTopologyActionNotifier.java` — duplicated from storm-core test sources ## Test plan - [x] All 36 tests pass: `mvn test -pl storm-server -Dtest=NimbusClojurePortTest` - [ ] Verify no regressions in full storm-server test suite 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
