jnioche commented on issue #8445: URL: https://github.com/apache/storm/issues/8445#issuecomment-4149627426
# Clojure-to-Java Test Port — Coverage Report
## Fully Ported Files (11/13)
| Clojure file | Java port |
|---|---|
| `cluster_test.clj` | `ClusterStateTest.java` |
| `drpc_test.clj` | `DRPCIntegrationTest.java` |
| `grouping_test.clj` | `GroupingIntegrationTest.java` |
| `metrics_test.clj` | `MetricsIntegrationTest.java` |
| `scheduler_test.clj` | `SchedulerModelTest.java` |
| `multitenant_scheduler_test.clj` | `MultitenantSchedulerTest.java` |
| `nimbus_auth_test.clj` | `NimbusAuthTest.java` |
| `trident/tuple_test.clj` | `TridentTupleViewTest.java` |
| `trident/integration_test.clj` | `TridentIntegrationTest.java` |
| `versioned_store_test.clj` | `VersionedStoreTest.java` |
| `nimbus_test.clj` | `NimbusClojurePortTest.java` — **36/40 tests
ported** |
## Files Not Requiring a Port (2/13)
- **`daemon_config.clj`** — Not a test. Generates Clojure constants from
`DaemonConfig` Java fields; only useful for the Clojure DSL.
- **`serialization_test.clj`** — Already migrated (comment in file: *"We
have moved needed tests to SerializationTest"*). Only tests round-tripping of
Clojure-specific data structures (keywords, sets).
## Missing Tests in `nimbus_test.clj` (4 remaining)
| Clojure test | What it covers |
|---|---|
| `test-leadership` | Verifies a non-leader Nimbus cannot
submit/kill/activate/deactivate/rebalance topologies. Uses `MockLeaderElector`
to stand up a leader and a non-leader. |
| `test-file-bogus-download` | Verifies `beginFileDownload` throws
`IllegalArgumentException` for null, empty, and bogus paths. |
| `test-stateless-with-scheduled-topology-to-be-killed` | Regression test
for STORM-856: Nimbus restarts cleanly when a topology is in "to be killed"
state in ZooKeeper. |
| `test-topology-action-notifier` | Verifies
`InMemoryTopologyActionNotifier` receives correct action sequence (submit,
activate, deactivate, activate, rebalance, kill) for a topology lifecycle. |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
