rzo1 opened a new pull request, #8540:
URL: https://github.com/apache/storm/pull/8540
The custom version-info Mojo in storm-buildtools/storm-maven-plugins only
populated SCM commit/branch/uri, build time and a source MD5 used to filter
storm-{client,core}-version-info.properties at build time. All of that is
covered by io.github.git-commit-id:git-commit-id-maven-plugin (commit, branch)
plus the plugin's own build timestamp, so the bespoke module is no longer
needed.
- Drop storm-buildtools/ tree (storm-maven-plugins module + leftover empty
maven-shade-clojure-transformer dir from the Clojure removal).
- Remove the storm-buildtools/storm-maven-plugins module from the root pom.
- Manage git-commit-id-maven-plugin 9.0.1 in the parent pluginManagement.
- Wire it into storm-client and storm-core in the initialize phase.
- Update version-info templates to reference git.commit.id, git.branch and
git.build.time. Drop srcChecksum from the templates (runtime VersionInfo
already returns "Unknown" when the property is absent, preserving the
IVersionInfo API and REST cluster-summary shape).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
