GGraziadei commented on issue #8585: URL: https://github.com/apache/storm/issues/8585#issuecomment-4395363892
Hi @rzo1, I have explored several paths for this update. First, I found the targeting version 12.3.1 (according to the compatibility matrix), as it is the last checkstyle version developed with Java 17, ensuring maximum compatibility with the maven-checkstyle-plugin. I’ve evaluated two main strategies: Strategy 1: Update the ceckstyle configuration. This involves adopting updated rules (e.g., [Google Checks 12.3.1](https://github.com/checkstyle/checkstyle/blob/checkstyle-12.3.1/src/main/resources/google_checks.xml)) and skipping auto-generated code. Pros: Up-to-date standards. Cons: This would require touching almost every file in the project, which may not provide enough benefit to justify the effort. Strategy 2: Keep custom rules but fix mandatory violations. This would involve keeping our current rules while fixing only the mandatory violations introduced by the new version. Even when using tools like OpenRewrite https://docs.openrewrite.org/ to automate the process, a large percentage of files would still need modifications. In both cases, the cost-benefit analysis leans negative. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
