GGraziadei commented on code in PR #8653:
URL: https://github.com/apache/storm/pull/8653#discussion_r3233201110
##########
pom.xml:
##########
@@ -514,6 +515,12 @@
<artifactId>commons-compress</artifactId>
<version>${commons-compress.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.github.luben</groupId>
+ <artifactId>zstd-jni</artifactId>
+ <version>${zstd-jni.version}</version>
+ <scope>compile</scope>
Review Comment:
I have removed the redundant <scope>compile</scope> tags as suggested.
Regarding the zstd-jni dependency: I have confirmed that it is marked as
`<optional>true</optional> `in the [commons-compress 1.28.0
POM](https://repo1.maven.org/maven2/org/apache/commons/commons-compress/1.28.0/commons-compress-1.28.0.pom).
I must keep this explicit dependency to ensure the artifact is included in the
classpath.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
