GGraziadei commented on PR #8706: URL: https://github.com/apache/storm/pull/8706#issuecomment-4532984646
Thanks for the detailed review and the helpful insights! I have applied all the requested changes. Added the exclusion for Grafana json dashboards in the root pom.xml and verified locally with mvn apache-rat:check -Prat. Removed the references and configurations related to the unmerged tuple compression feature (apologies for the distraction and mixing the PR contents!). Bound all published ports to 127.0.0.1 in docker-compose.yml to prevent LAN exposure. Updated the README to state the Linux/macOS/WSL2 requirement explicitly, and resolved the hardcoded container names in netsim.sh, fixed the versioning fallback in prepare-extlib.sh, and added the missing trailing newline for a json file. Everything is now pushed and ready for another look! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
