rzo1 commented on PR #8783:
URL: https://github.com/apache/storm/pull/8783#issuecomment-4630867346
Nice, well-scoped feature that rides on Storm's native component-config
mechanism.
1. Bolt config is applied once per incoming stream, not once per bolt. The
block applying memory/CPU/tasks/config runs on every iteration of the streams
loop, so a bolt with N inputs calls validateFields() + addConfigurations() N
times on the same declarer. It's idempotent, so not a bug, and it matches the
existing pattern for setMemoryLoad/setCPULoad/setNumTasks (just redundant=
2. Validation asymmetry. buildConfig() applies the topology-wide config:
with no ConfigValidation, while this PR validates per-component config.
Fail-fast is the better behavior, but the asymmetry (an invalid-typed value
passes topology-wide yet fails per-component) may surprise users. Consider
validating the topology config too in a follow-up, or noting the difference.
3. README clarity. "Known Storm configuration keys are validated …" is
accurate but could read as blanket validation. Suggest adding: "Unknown/custom
keys are not validated and are passed through verbatim; validation runs
client-side at build time."
4. Nit: new HashMap<String, Object>() in VertexDef → diamond <> to match
the codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
