GGraziadei commented on code in PR #8593:
URL: https://github.com/apache/storm/pull/8593#discussion_r3407808595
##########
storm-client/src/jvm/org/apache/storm/Config.java:
##########
@@ -608,8 +608,45 @@ public class Config extends HashMap<String, Object> {
*
* @see <a href="https://www.rfc-editor.org/rfc/rfc1889#appendix-A.8";>RFC
1889 §A.8</a>
*/
- @CustomValidator(validatorClass =
ConfigValidation.EwmaSmoothingFactorValidator.class)
+ @CustomValidator(validatorClass =
ConfigValidation.ZeroOneOpenIntervalValidator.class)
public static final String TOPOLOGY_STATS_EWMA_SMOOTHING_FACTOR =
"topology.stats.ewma.smoothing.factor";
+ /**
+ * Flag to enable or disable the feedback channel for upstream
communication.
+ * When true, components can send unanchored tuples back to their source
tasks.
+ */
+ @IsBoolean
+ public static final String TOPOLOGY_UPSTREAM_FEEDBACK_ENABLE =
"topology.upstream.feedback.enable";
+ /**
+ * The specific stream ID used for upstream feedback communication.
+ * Defaults to "__feedback" if not explicitly configured.
+ */
+ @IsString
+ public static final String TOPOLOGY_UPSTREAM_FEEDBACK_STREAM_ID =
"topology.upstream.feedback.stream";
Review Comment:
Thank you, I completely agree. I am moving it in Constants.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
