reiabreu opened a new pull request, #8811:
URL: https://github.com/apache/storm/pull/8811

   ## Summary
   
   - Makes `IsolationScheduler#hostAssignableSlots` package-private and 
annotates it with `@VisibleForTesting`
   - Removes the reflection-based wrapper in `IsolationSchedulerTest` that 
called `setAccessible(true)` to reach the private method
   - Tests now call `hostAssignableSlots` directly; `throws Exception` removed 
from both test signatures
   
   ## Motivation
   
   As suggested in 
https://github.com/apache/storm/pull/8709#discussion_r3463986567 — 
reflection-based test helpers are fragile (silently break on method renames, 
signature changes, or module boundary changes) and harder to maintain. The 
`@VisibleForTesting` pattern is already used elsewhere in `storm-server` (e.g. 
`Supervisor.java`) and makes the intent explicit without exposing the method 
publicly.
   
   ## Test plan
   
   - [ ] `mvn test -pl storm-server -Dtest=IsolationSchedulerTest` passes
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to