reiabreu opened a new pull request, #8813:
URL: https://github.com/apache/storm/pull/8813

   ## Summary
   
   Several inaccuracies, missing steps, and minor errors have accumulated in 
`RELEASING.md`. This PR addresses all of them in one pass.
   
   **P1 – Critical (process correctness)**
   - Step 4: add `-P dist` flag to `mvn clean install` and explicit `mvn 
package` commands for `storm-dist/binary` and `storm-dist/source` submodules — 
without these the distribution artifacts are never built
   - Step 3: add note to record the Nexus staging repository ID; it is required 
in the vote email template
   - Step 2: add `mvn release:clean` recovery note for mid-build failures
   - Step 9/10: split "move files" from "svn add + svn commit" into two 
numbered steps, filling the 9→11 gap and providing the actual SVN commands
   - Step 1 of vote (`svn mv`): add `-m "..."` commit message flag (SVN 
requires it)
   - Fix step reference "Step 1" → "Step 2" in step 4
   
   **P2 – High (missing guidance)**
   - Add GPG KEYS file maintenance instructions (svn checkout, `gpg --export 
--armor`, svn commit) — currently missing, leaving release managers without 
guidance on adding their key
   - Add macOS `shasum -a 512` note for step 5
   - Clarify Maven may already generate `.sha512` files so release managers 
don't overwrite them needlessly
   - Fix truncated `GITHUB_TOKEN` placeholder 
(`MY_PERSONAL_ACCESS_TOKEN_FOR_GI` → `<your-github-pat>`)
   
   **P3 – Medium (broken links / formatting)**
   - Fix all `http://` links to `https://` (lines 18, 19, 194, 206, 257, 259)
   - Fix KEYS URL: `www.apache.org/dist/storm/KEYS` → 
`downloads.apache.org/storm/KEYS`
   - Fix `[VERSION]]` → `[VERSION]` in vote email subject
   - Change ` ```agsl ` code fences → ` ```text ` for email templates (agsl is 
not a recognized language)
   - Add missing "by" in "followed by `mvn release:perform`"
   - Fix version example inconsistency (`2.6.x-branch` / `2.3.0-SNAPSHOT` → 
`2.7.x-branch` / `2.8.0-SNAPSHOT`)
   - Fix "Releasing if vote succeeds" step numbering gap (8 → 10, skipping 9)
   
   **P4 – Low (typos and step ordering)**
   - Fix typos: `migh` → `might`, `Annoucement` → `Announcement`, `Sent email` 
→ `Send a`, `deactivate, deactivate` → `deactivate, activate`, `funcionalities` 
→ `functionalities`
   - Reorder "Cleaning up if vote fails": artifact cleanup steps (drop staging 
repo, delete SVN files, delete tag) now come before the cancellation email
   
   ## Test plan
   
   - [ ] Read through the full document to verify the flow makes sense 
end-to-end
   - [ ] Verify all URLs are reachable
   - [ ] Confirm step numbering is now contiguous in both "Setting up a vote" 
(1–11) and "Releasing if the vote succeeds" (0–11)
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to