reiabreu commented on PR #8593:
URL: https://github.com/apache/storm/pull/8593#issuecomment-4826942470
@rzo1 has already done the heavy lifting in this PR, thanks for that.
Only very minor stuff left.
> CAn you resolve the open onflicts?
@GGraziadei there are still some open conversations. Do you mind resolving
them?
- We should make it clear in the documentation that this new grouping does
**not** guarantee ordering of tuples, since it's a sub-case of Load Aware
grouping.
- > My honest read of the result: at max.spout.pending=500 JitterAware gives
a consistent ~5–7% complete-latency reduction over load-aware (with and without
the injected network jitter), at comparable throughput. At
max.spout.pending=1000 that advantage disappears — JitterAware is roughly
equal-to-slightly-worse there. With 2–3 reps and no variance reported, the ~5%
delta is close to the rep-to-rep spread, so I'd describe this as "neutral
overhead, directionally better latency at moderate load" rather than a
throughput win. That's still a reasonable case for the feature as an opt-in, I
just want the PR description / docs to frame it that way rather than as a
general improvement.
- We should also point out what @rzo1 commented above
Thanks for the great PR. Touches on a lot of complex concepts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
