reiabreu commented on code in PR #8983:
URL: https://github.com/apache/storm/pull/8983#discussion_r3817560805
##########
external/storm-hdfs-oci/src/main/java/org/apache/storm/container/oci/LocalOrHdfsImageTagToManifestPlugin.java:
##########
@@ -229,6 +239,10 @@ private static Map<String, String>
readImageToHashFile(BufferedReader br, String
@Override
public synchronized ImageManifest getManifestFromImageTag(String imageTag)
throws IOException {
String hash = getHashFromImageTag(imageTag);
+ if (!isValidHash(hash)) {
Review Comment:
another minor one caught by LLM: hdfsImageToHash and localImageToHashCache
are built from readImageToHashFile, which already does this validation. It's
not necessarily wrong to have this here, since it's defensive in case
readImageToHashFile changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
