rzo1 opened a new pull request, #8998:
URL: https://github.com/apache/storm/pull/8998

   `SimpleACLAuthorizer.permit()` short-circuited on `nimbusUsers.size() == 0` 
and allowed the call, so `nimbus.groups` was never consulted when 
`nimbus.users` was left empty. An operator locking the cluster down by group 
alone therefore got no restriction at all.
   
   All four combinations are now evaluated; both-empty still means no 
restriction, which is the shipped default. Extends `SimpleACLAuthorizerTest`.
   
   Note: a cluster that set `nimbus.groups` without `nimbus.users` will now 
restrict user-level commands to members of those groups. That includes 
`NimbusClient.getConfiguredClientAs`, which calls `getLeader()` on every 
connection.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to