GGraziadei opened a new pull request, #9004:
URL: https://github.com/apache/storm/pull/9004

   ## Summary
   
   - `AuthorizedUserFilter` no longer skips authorization when a resource 
method carries no `@AuthNimbusOp`; such a request is now rejected.
   - Endpoints that intentionally have no operation gate declare it with the 
new `@UnauthenticatedNimbusOp`, so the choice is explicit and reviewable. 
`/history/summary` uses it, since Nimbus already filters that response for the 
authenticated remote user.
   - `/cluster/configuration` is gated on `getNimbusConf`, matching the ACL the 
direct Thrift path applies.
   - `getNimbusConf` returns the config through `ConfigUtils.maskPasswords`, as 
`getTopologyConf` already does.
   - Adds the missing `@Password` markers to credential-bearing keys in 
`Config.java` (cluster ZooKeeper auth payload, Thrift and Netty TLS store 
passwords). These were absent, so those values were also reaching daemon logs 
through the existing masking call sites.
   
   ## Compatibility
   
   The filter is registered only for `org.apache.storm.daemon.ui.resources`, 
which holds a single resource class; all its endpoints declare one of the two 
annotations. A new endpoint added without either annotation is rejected until 
it declares one, which is the intent.
   
   ## Testing
   
   - `mvn -pl storm-client test -DskipITs` — 659 tests, 0 failures
   - `mvn -pl storm-webapp test -DskipITs` — 99 tests, 0 failures
   - `mvn -pl storm-server test -DskipITs` — 491 tests, 0 failures
   - New tests cover the filter decision for gated, opted-out and undeclared 
endpoints, the annotation coverage of every API endpoint, and the masking of 
the served configuration.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to