reiabreu commented on PR #9011: URL: https://github.com/apache/storm/pull/9011#issuecomment-5388113513
_Disclaimer: this comment was generated with the help of an LLM._ The added cleanup tests are thorough — the reference-counting, the fail-safe fallback, and the UUID-shape edge cases are all well covered. One small coverage gap: `referencedDependencyKeys` treats a `KeyNotFoundException` (a candidate topology with no code blob) as contributing no references and *continues* the scan, which is a different branch from the read-failure path that `doCleanupReclaimsOnlyProvablyUniqueDependencyBlobsWhenTheReferencesCannotBeRead` exercises (an `IOException` that aborts the scan and triggers the fallback). A test with a candidate topology whose code blob is missing — asserting the scan still succeeds and the other topologies' references are honored — would close that branch. Non-blocking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
