reiabreu commented on PR #9010: URL: https://github.com/apache/storm/pull/9010#issuecomment-5393489794
Thank you for the feedback, @rzo1. I'm afraid I haven't touched C in many years, so I relied entirely on Claude for these fixes. - **1 (symlink bypass):** `is_valid_mount_source` now resolves the source and each configured directory with `realpath` before the containment check and rejects unresolvable sources. Docs drop the `/data/storm` example and state that only directories the topology user cannot write to should be listed (runc re-resolves at mount time — residual TOCTOU). Added a symlink-escape test. - **2 (degenerate config values):** Split into #9013, since the helper bug affects every `get_values` caller. There `extract_values_delim` NUL-terminates the zero-token case and `get_values` returns independently-owned strings so `free_values` no longer frees an interior pointer; includes a regression test that aborts on the pre-fix code. - **3 (`/` allowed dir):** Documented that `/` isn't a usable entry (a path is accepted only when it equals or sits under a listed directory as a whole component). - **4 (enforcement-point tests):** The `parse_oci_launch_cmd`-level and username-mismatch tests need `main.c` linked into the test binary — same deferred test-harness change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
