reiabreu commented on PR #9008: URL: https://github.com/apache/storm/pull/9008#issuecomment-5393489574
Thank you for the feedback, @rzo1. I'm afraid I haven't touched C in many years, so I relied entirely on Claude for these fixes. - **1 (`--`):** `cleanup_oci_container` now execs `runc delete -- <id>`, so an option-shaped id can't be parsed as a flag. - **2 (test nit / coverage):** Replaced the 24-char case (rejected by the length check) with a 40-char invalid-charset case that actually exercises the character check. `cleanup_oci_container` and the `main.c` rejection branch still aren't run because `main.c` isn't linked into the test binary — left for a separate change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
