GGraziadei commented on code in PR #9094:
URL: https://github.com/apache/storm/pull/9094#discussion_r4076490044
##########
storm-client/src/jvm/org/apache/storm/messaging/DeserializingConnectionCallback.java:
##########
@@ -104,7 +110,7 @@ public void recv(List<TaskMessage> batch) {
try {
tuple = des.deserialize(message.message());
} catch (Exception e) {
- if (!isToleratedDeserializationFailure(e)) {
+ if (strictMode || !isToleratedDeserializationFailure(e)) {
throw e;
Review Comment:
When a compressed frame is broken or too large, it throws an error. In
strict mode, we expect this error to stop the worker, but Netty catches it,
logs it, closes the connection, and keeps the worker running. This means one
bad frame can cause all valid tuples in the same batch to be lost. The peer
must reconnect, and no failure metric is increased.
This is confusing because the documentation says that strict mode should
terminate the worker. We should either change the behavior or update the
documentation.
wdyt?
##########
storm-client/src/jvm/org/apache/storm/serialization/TupleDeserializationException.java:
##########
@@ -0,0 +1,26 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
ASF licenses this file to you under the Apache License, Version
+ * 2.0 (the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions
+ * and limitations under the License.
+ */
+
+package org.apache.storm.serialization;
+
+/**
+ * Thrown when a serialized tuple names a source task or stream that the
receiving topology cannot resolve.
+ */
+public class TupleDeserializationException extends IllegalArgumentException {
Review Comment:
The new entry in the tolerated-failures list is not needed because
TupleDeserializationException already extends IllegalArgumentException, which
is already in the list.
The list is here
https://github.com/apache/storm/pull/9094/changes#diff-e9421c851286d22152559b22fc546c160cf2ed1dce13f719783617b5f73e19dfR49
If the goal is to treat `TupleDeserializationException` separately, it
should extend `RuntimeException ` instead. Otherwise, the PR description and
the comment should be updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
