rzo1 opened a new pull request, #9151: URL: https://github.com/apache/storm/pull/9151
Replaces #9103 and #9121. Surefire 3.6.0 removes the native TestNG provider (`surefire-testng` 3.6.0 is not published). TestNG tests now run through the JUnit Platform `testng-engine`, which broke the integration tests with "TestEngine with ID 'testng' failed to discover tests". - The engine instantiates test classes during discovery. `AbstractTest` created its `StormCluster` (and so its Nimbus connection) in a field initializer, so discovery failed. It now connects in a `@BeforeClass(alwaysRun = true)` method. - The `listener` surefire property is TestNG-provider specific. `TestngListener` is now registered through the engine's `testng.listeners` configuration parameter. Verified locally that it still logs test start/end. Side effect: storm-starter's TestNG tests now actually run. With 3.5.6 surefire picked the JUnit Platform provider and ran 0 of them; with 3.6.0 all 226 run and pass locally. Locally, without a cluster, integration-test discovery succeeds and the run fails as expected in `@BeforeClass`; CI covers the real cluster run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
