reiabreu commented on PR #9097: URL: https://github.com/apache/storm/pull/9097#issuecomment-5993267119
*This comment was generated with the help of an LLM (Claude) and reviewed by me before posting.* Two points in my earlier review were wrong; @rzo1 is right on both: - Please keep `isVirtualEnabled()` as is. `ObjectReader.getBoolean` throws on a `String`, which would break the `-Dstorm.options=...=true` case. - The worker shared pool change is not a security concern, since the pool lives in the submitter's own worker, which already runs their code. It's a `topology.*` key that used to be ignored and is now honored, which is worth a line in the description. The rest of my review stands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
