jnioche commented on PR #9158: URL: https://github.com/apache/storm/pull/9158#issuecomment-6123031554
Thanks @rzo1 for the thorough review! All the suggestions are applied in b03f38f54: - **Counter vs scoped gauge on the same task**: counters and meters are now converted before gauges, and the `.m1_rate` gauge is skipped for any `RateCounter`, not only those under `__`. Covered by `counterSharingFamilyWithScopedGauge`, which failed before the change. - **Type conflicts across tasks**: `Families` keeps the points per type. When types collide, every type gets a suffix (`fetcher_counter`, `fetcher_gauge`, `fetcher_summary`), so nothing is dropped and the result no longer depends on iteration order. Covered by `familyWithDifferentTypesInTwoTasks`, which failed before. This also changes the same-task case above: it now exports `pages_counter_total` and `pages_gauge`. The README Naming section documents it. - **Netty client gauges**: the trailing `-<host>:<port>` of `__send-iconnection-*` becomes `remote_host`/`remote_port` labels. Covered by `stormConnectionMetric` (failed before) and listed in the README. - **Out of range port**: `start()` catches `IOException | IllegalArgumentException`, so the worker keeps running and the error is logged. Covered by `portOutOfRangeDoesNotFailStart`, which failed before with `port out of range:70000`. - **Explicit `port` under a supervisor**: `resolvePort` logs a warning, and the README says `port` is meant for local mode. - **Shared endpoint settings**: `Endpoint` keeps `host` and `jvmMetrics`, and a warning is logged when a later reporter asks for different values. The README says the first reporter's settings apply. - **JVM metrics leak**: the JVM metrics are registered once on a static registry that every endpoint delegates to. `jvmMetricsAfterEndpointRestart` checks that the JVM metrics are still served after an endpoint is closed and recreated. It can't show the leak itself, so it passed before the change too. All the module tests pass and `mvn verify` (including PMD) succeeds. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
