sercuzz8 commented on code in PR #9017: URL: https://github.com/apache/storm/pull/9017#discussion_r4262518712
########## storm-checkstyle/src/main/resources/storm/normalize-license-headers.groovy: ########## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/* + * Rewrites the leading license comment of the files of a module (Java, Groovy, XML, Markdown, + * YAML, properties, Python and shell) to the exact template of + * https://www.apache.org/legal/src-headers.html#headers. + * + * A file is left alone when its leading comment is not an ASF license header, or when it carries + * a copyright notice of anybody but the ASF (third-party works keep their own notice). + * + * Run on demand via gmavenplus-plugin's `execute` goal (execution id `normalize-license-headers`, + * bound to no phase); see storm-checkstyle/README.md. With -Dlicense.check=true nothing is + * written and the build fails if a file would change. + */ + +final List<String> TEXT = '''\ Review Comment: Hello @GGraziadei, I have rechecked and indeed both license headers were accepted but the "to You" version was still touched due to some other perks (e.g. the double spaces after the period in ". See"). I have made addressed it with the first new commit, furthermore, I have made the groovy autofix files themselves untouchable in the second new one ########## storm-checkstyle/src/main/resources/storm/normalize-license-headers.groovy: ########## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/* + * Rewrites the leading license comment of the files of a module (Java, Groovy, XML, Markdown, + * YAML, properties, Python and shell) to the exact template of + * https://www.apache.org/legal/src-headers.html#headers. + * + * A file is left alone when its leading comment is not an ASF license header, or when it carries + * a copyright notice of anybody but the ASF (third-party works keep their own notice). + * + * Run on demand via gmavenplus-plugin's `execute` goal (execution id `normalize-license-headers`, + * bound to no phase); see storm-checkstyle/README.md. With -Dlicense.check=true nothing is + * written and the build fails if a file would change. + */ + +final List<String> TEXT = '''\ Review Comment: Hello @GGraziadei, I have rechecked and indeed both license headers were accepted but the "to You" version was still touched due to some other perks (e.g. the double spaces after the period in ". See"). I have addressed it with the first new commit, furthermore, I have made the groovy autofix files themselves untouchable in the second new one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
