Mohit20057 opened a new pull request, #9171:
URL: https://github.com/apache/storm/pull/9171
## What is the purpose of the change
Part of Umbrella Issue #8994 (Sub-task 6: Inventory deprecated API and
formalize deprecation decisions).
The Pacemaker subsystem was previously marked with `@Deprecated` and
documentation stating that it is kept only for backward compatibility and will
be removed in a future release, but lacked the formal `since = "3.1.0",
forRemoval = true` attributes on its annotations.
This PR upgrades the deprecation annotations to `@Deprecated(since =
"3.1.0", forRemoval = true)` across:
1. `storm-client` configuration keys:
- `Config.PACEMAKER_SERVERS`
- `Config.PACEMAKER_PORT`
- `Config.PACEMAKER_CLIENT_MAX_THREADS`
- `Config.PACEMAKER_AUTH_METHOD`
- `Config.PACEMAKER_THRIFT_MESSAGE_SIZE_MAX`
2. `storm-client` Pacemaker classes:
- `PaceMakerStateStorage`
- `PaceMakerStateStorageFactory`
- `PacemakerClient`
- `PacemakerClientHandler`
- `PacemakerClientPool`
- `PacemakerConnectionException`
- `ThriftDecoder`
- `ThriftEncoder`
- `ThriftNettyClientCodec`
3. `storm-server` configuration keys:
- `DaemonConfig.PACEMAKER_MAX_THREADS`
- `DaemonConfig.PACEMAKER_CHILDOPTS`
4. `storm-server` Pacemaker classes:
- `IServerMessageHandler`
- `Pacemaker`
- `PacemakerServer`
- `PacemakerServerHandler`
- `ThriftNettyServerCodec`
## How was the change tested
- Ran `mvn test-compile -pl storm-client,storm-server` with JDK 23:
- 0 Checkstyle violations.
- Verified clean build (`BUILD SUCCESS`) and confirmed compiler
deprecation warnings for removal across all modified items.
- Ran test suites:
- `storm-server`: `PacemakerServerTest`, `PacemakerTest`,
`DaemonConfigTest` (24/24 passed).
- `storm-client`: `ThriftDecoderTest`, `PaceMakerStateStorageFactoryTest`,
`TestConfigValidate` (58/58 passed).
## Checklist
- [x] Pull request title conforms to conventional style
- [x] Code is clean of checkstyle issues
- [x] Relevant tests pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
