reiabreu commented on PR #9153:
URL: https://github.com/apache/storm/pull/9153#issuecomment-6235407597
*This comment was generated with the help of an LLM (Claude) and reviewed by
me before posting.*
A correction to my first review: I wrote that
`nimbus.supervisor.timeout.secs` lets Nimbus tolerate missed heartbeats (about
12 at the 60 s default), and my suggested code comment said the same. That was
wrong. The key is deprecated since 3.1.0 and nothing reads it, as #9170 notes
(I checked: in v3.1.0 only its declaration and `defaults.yaml` mention it).
A skipped heartbeat is still harmless, for a different reason: Nimbus tracks
supervisors through ephemeral ZooKeeper nodes, which stay while the session is
alive, and the next heartbeat recreates the node if it was lost. The comment
already in the PR ("Liveness is tracked via ephemeral ZK nodes, not this write.
Safe to skip.") is correct. Please keep it and disregard my suggested wording.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
