sharanggupta opened a new pull request, #9186:
URL: https://github.com/apache/storm/pull/9186
## What is the purpose of the change
The JUnit 5 migration (STORM-3832, #3479) replaced `@Test(expected =
IllegalArgumentException.class)` with `assertThrows` in
`TCKTest.testInvalidTopologySource` and in the storm-hdfs bolt
`TestSimpleFileNameFormat.testTimeFormat`, but also dropped `@Test`, so neither
test has run since. This adds `@Test` back to both.
In `testTimeFormat` the exception is thrown by `withTimeFormat("xyz")`, not
by `prepare`, so that call moves inside `assertThrows`, as the trident
`TestSimpleFileNameFormat` already does. With only the annotation restored, the
test errors out.
## How was the change tested
`mvn -pl external/storm-hdfs,flux/flux-core -am verify
-Dtest='TCKTest,TestSimpleFileNameFormat'` on JDK 25: all tests pass and
checkstyle is clean. Each test also fails when its input is made valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
