reiabreu commented on PR #9168: URL: https://github.com/apache/storm/pull/9168#issuecomment-6377700375
> > Hi @rzo1 @reiabreu, > > Thanks for the review! I have added a `LOG.warn(...)` in `Nimbus` when a submitted topology specifies `topology.backpressure.enable`. Here is the Release & Upgrade Note for this PR: > > ### Release & Upgrade Note: Removal of Legacy ZooKeeper Backpressure State > > > > 1. **Removal of `Config.TOPOLOGY_BACKPRESSURE_ENABLE`**: > > > > * The public constant `Config.TOPOLOGY_BACKPRESSURE_ENABLE` (`"topology.backpressure.enable"`), originally marked for removal in 2.0.0, has been removed. > > * Worker backpressure in modern Storm versions is automatically handled in-process via internal worker queues/buffering; the legacy ZooKeeper-coordinated backpressure toggle is obsolete. Topologies submitting this key will now receive a log warning. > > 2. **ZooKeeper `/backpressure` Znodes Cleanup Notice**: > > > > * The legacy cluster-state methods (`backpressure()`, `setupBackpressure()`, `removeBackpressureFlag()`, etc.) and the associated cleanup routine in Nimbus have been removed. > > * **Notice for Cluster Operators**: Clusters upgraded from legacy 1.x installations (or topologies that previously used ZooKeeper-based backpressure) will no longer have lingering `/backpressure` znodes automatically purged by Nimbus. Operators can safely delete any orphaned historical znodes directly in ZooKeeper using the zkCli tool (`rmr /storm/backpressure` or `deleteall /storm/backpressure`). > > thanks @Mohit20057 ! Do you mind resolving the conflicts? A couple of issues come to mind: > > * the umbrella issues mentions that API removal should be done in a major. Next release, however, will be 3.2.0. We do have a precedent of doing something similar and putting in master before a major release: [Remove deprecated NIMBUS_SUPERVISOR_TIMEOUT_SECS and defaults entry (#8994) #9170](https://github.com/apache/storm/pull/9170) > * Our current process of generating release notes still contains a good bit of manual steps by the person cutting the release, so this kind of detailed "release & upgrade notes" will get lost unless manually moved to the notes during the release, since it's only a comment in a PR @rzo1 @GGraziadei . Will try to think of something to improve our process Asked Claude to quickly change the release notes script to capture "Upgrade notes" section from the PRs. https://github.com/apache/storm/pull/9189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
