sharanggupta opened a new pull request, #9251:
URL: https://github.com/apache/storm/pull/9251

   ## What is the purpose of the change
   
   `getLogHandler_notFound` and `getLogHandler_notAShellLogHandler` only built 
a config map and never called `ShellUtils.getLogHandler`, so they have checked 
nothing since STORM-2862. They now call it with `assertThrows` and check the 
cause, as their Javadoc describes.
   
   ## How was the change tested
   
   `ShellUtilsTest` runs 5 tests, all passing, and checkstyle is clean. With 
`getLogHandler` falling back to the default handler instead of throwing, both 
tests fail.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to