reiabreu commented on issue #8994:
URL: https://github.com/apache/storm/issues/8994#issuecomment-6712947172

   *Generated with the help of an LLM.*
   
   **Status of this umbrella: the first round is done, and the issue stays open 
for the items below.**
   
   **Done in 3.2.0** (checked against `master`)
   - The inventory and classification are merged (#9172, #9173).
   - The removals whose window had passed are merged (#9167–#9170). None of 
`BlowfishTupleSerializer`, `NIMBUS_SUPERVISOR_TIMEOUT_SECS`, the five ZooKeeper 
backpressure methods or `TOPOLOGY_BACKPRESSURE_ENABLE` is referenced in Java 
code any more.
   - Pacemaker is marked `forRemoval` (#9171).
   - The removals have upgrade notes in the PR descriptions (#9167–#9171, plus 
#9168 and #9169), so they appear in the release notes.
   
   **Still to do**
   1. **Finish the annotation cleanup.** An audit of the 103 `@Deprecated` 
annotations in production code on `master` (84 `forRemoval = true`, 10 `false`) 
found 12 that still miss `since`, which contradicts the earlier "zero bare" 
count. Each needs a `since` and a `forRemoval` decision:
      - `Flux.java`: four private CLI option constants, `OPTION_LOCAL`, 
`OPTION_REMOTE`, `OPTION_SLEEP`, `OPTION_ZOOKEEPER`. They have no javadoc, and 
the options are already documented as "Ignored" in the help text.
      - `NodeSorter.java` and `NodeSorterHostProximity.java`: two private 
methods each, `sortObjectResourcesGeneric` and `sortObjectResourcesDefault`. 
Their javadoc names the replacement.
      - `ServerUtils.zipFileSize`: public, javadoc says it is unused and will 
be removed.
      - `LinearDRPCTopologyBuilder.addBolt(IRichBolt…)`, two overloads: 
`forRemoval = true` but no `since`.
      - `TimeCacheMap`: `forRemoval = false` but no `since`.
   
      Also, a check of the javadoc found six `@deprecated` tags with no obvious 
replacement named: `PlainSaslTransportPlugin`, `SaslPlainServer`, the three 
`IMetricsContext.registerMetric` overloads, and `ServerUtils.zipFileSize`. 
These need a look.
   2. **Remove what is marked `forRemoval = true`.** 84 annotations remain, in 
`storm-client` (54), `storm-server` (18) and `external/storm-hdfs` (12). Each 
removal should go in as its own reviewable PR with tests, docs and an upgrade 
note.
   3. **Decide on the OpenRewrite idea.** The "Find Deprecated Uses" action 
suggested on 2026-10-18 has not produced a PR.
   4. **Document the deprecations.** `docs/` has no page that lists deprecated 
or removed APIs, so removals are only in PR descriptions and release notes.
   
   **Why this stays open:** the issue's scope also includes classifying every 
surviving item and removing what is due. Items 1 to 4 are the remaining work, 
and the list above is the checklist for closing it. When they are done, or 
split into their own issues, this umbrella can be closed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to