reiabreu opened a new pull request, #9267:
URL: https://github.com/apache/storm/pull/9267

   The 3.2.0 candidate has two binary tarballs built from the same tag, and 
`jspecify-1.0.1.jar` sits in `lib/` in one and in `lib-common/` in the other.
   
   **Cause**
   - `storm-shaded-deps` is built with the shade plugin, whose 
dependency-reduced pom lists `jspecify` as a compile dependency.
   - A module that resolves `storm-shaded-deps` from the local Maven repository 
sees that pom. So `jspecify` is copied into `lib-worker`, and `dedup-libs.py` 
moves it to `lib-common`. This is the rebuild from the tag.
   - In a reactor build, as `release:perform` does, Maven reads the source pom, 
where `jspecify` is only reachable through JUnit as a test dependency. It is 
not copied into `lib-worker`, so it stays in `lib`.
   
   **Change**
   - Declare `org.jspecify:jspecify` in 
`storm-dist/binary/storm-client-bin/pom.xml`. The version is already managed in 
the root pom, so no version is set here. Both build modes now give the same 
worker jars, and `jspecify` ends up in `lib-common`.
   
   **Verified** on a scratch checkout of the `v3.2.0` tag with this change:
   - `storm-client-bin` built in a reactor (`-am`, with `-P 
dist,rat,externals,examples`) and on its own (`-P dist`): `lib-worker` has 40 
jars in both, and the jar names and SHA-256 hashes are identical. Without the 
change the reactor build has 39 jars, without `jspecify`.
   - The pom validates on `master`.
   
   **Not verified:**
   - I did not rebuild the full tarballs in both modes and compare them. Build 
timestamps embedded in the UI files and the `branch=` line in the version-info 
files will still differ between any two builds.
   - I did not run this change through the smoke tests.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to